Conversation
There was a problem hiding this comment.
@LukeShu @youngnick note that this topic was discussed during a community meeting.
There was a problem hiding this comment.
I would use even stronger language and make it a requirement instead of a "general expectation". Perhaps we should also use the term "affiliation" rather than "organization" to distinguish it from GitHub orgs.
|
@LukeShu I would like all 3 organizations to review PRs during the early stages of the project, so PTAL and merge if all looks good to you. |
There was a problem hiding this comment.
We should provide links to GitHub and Slack as soon as the project and channels are made public.
There was a problem hiding this comment.
Yes, they will be added to the readme, xref.
There was a problem hiding this comment.
Thanks for creating the issue!
There was a problem hiding this comment.
We should change the repository's configuration to make "Squash and merge" the default.
There was a problem hiding this comment.
I would use even stronger language and make it a requirement instead of a "general expectation". Perhaps we should also use the term "affiliation" rather than "organization" to distinguish it from GitHub orgs.
I will update to use "affiliation" instead of "organization". I use "general expectation" due to the following caveat:
I have updated this bullet to clearly state this is required, PTAL. |
40777da to
1163c07
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
|
Had to rebase. PTAL and /approve if all looks good. |
LukeShu
left a comment
There was a problem hiding this comment.
I have no problems with this.
Adds a contrib doc based on Envoy and go-control-plane.
Fixes: #8
Signed-off-by: danehans daneyonhansen@gmail.com