fix: flaky e2e gateway_with_conflicted_listener_cannot_be_merged#3911
Merged
shawnh2 merged 7 commits intoenvoyproxy:mainfrom Jul 24, 2024
Merged
fix: flaky e2e gateway_with_conflicted_listener_cannot_be_merged#3911shawnh2 merged 7 commits intoenvoyproxy:mainfrom
shawnh2 merged 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3911 +/- ##
==========================================
- Coverage 67.39% 67.36% -0.04%
==========================================
Files 183 183
Lines 22435 22435
==========================================
- Hits 15121 15113 -8
- Misses 6226 6231 +5
- Partials 1088 1091 +3 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
zirain
reviewed
Jul 20, 2024
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Contributor
Author
|
/retest |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Contributor
Author
Done. Should we only enable |
Contributor
Author
|
/retest |
zirain
approved these changes
Jul 23, 2024
cnvergence
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3845