Skip to content

Added tabpane view to installation under latest version#3931

Closed
Manoramsharma wants to merge 1 commit intoenvoyproxy:mainfrom
Manoramsharma:docs-tabpane-new
Closed

Added tabpane view to installation under latest version#3931
Manoramsharma wants to merge 1 commit intoenvoyproxy:mainfrom
Manoramsharma:docs-tabpane-new

Conversation

@Manoramsharma
Copy link
Copy Markdown
Contributor

What type of PR is this?
Docs feature enhancement

What this PR does / why we need it:

This PR is made to enhance the docs, making it more presentable using tabpane installation.

Which issue(s) this PR fixes:

Fixes #3133

Before
Screenshot 2024-07-21 at 11 29 00 PM

After
Screenshot 2024-07-21 at 11 29 45 PM

Screenshot 2024-07-22 at 7 58 36 PM

Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
@Manoramsharma Manoramsharma requested a review from a team as a code owner July 22, 2024 14:29
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (fda9376) to head (6281a7c).
Report is 312 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3931      +/-   ##
==========================================
- Coverage   67.43%   67.38%   -0.06%     
==========================================
  Files         183      183              
  Lines       22435    22435              
==========================================
- Hits        15130    15117      -13     
- Misses       6218     6228      +10     
- Partials     1087     1090       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manoramsharma
Copy link
Copy Markdown
Contributor Author

Hi @zirain I have made the required changes to the latest version, passing the gen-check workflow check but why this Hugo Docs check is failing for it. Can you please give a review on this?

@zirain
Copy link
Copy Markdown
Member

zirain commented Jul 22, 2024

Hi @zirain I have made the required changes to the latest version, passing the gen-check workflow check but why this Hugo Docs check is failing for it. Can you please give a review on this?

[404] site/public/latest/install/install/api
[404] site/public/latest/install/install/install-helm
[404] site/public/latest/install/install-helm


### Increase the replicas

```shell
helm install eg oci://docker.io/envoyproxy/gateway-helm --version v0.0.0-latest -n envoy-gateway-system --create-namespace --set deployment.replicas=2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not change this, #3766 will fix this.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Aug 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Sep 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Oct 21, 2024
@zirain
Copy link
Copy Markdown
Member

zirain commented Oct 23, 2024

As we discussed, we won't need this for now.
I'd like to close this first, feel free to reopen.

@zirain zirain closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: use tabs to show different installation types

2 participants