Skip to content

reduce readinessProbe failureThreshold and periodSeconds #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Aug 9, 2024
Merged

reduce readinessProbe failureThreshold and periodSeconds #4021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ func expectedProxyContainers(infra *ir.ProxyInfra,
},
},
TimeoutSeconds: 1,
PeriodSeconds: 10,
PeriodSeconds: 5,
SuccessThreshold: 1,
FailureThreshold: 3,
FailureThreshold: 1,
},
Lifecycle: &corev1.Lifecycle{
PreStop: &corev1.LifecycleHandler{
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/component-level.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/default-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,12 +256,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/disable-prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,12 @@ spec:
name: EnvoyHTTPSPort
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/extension-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions .../infrastructure/kubernetes/proxy/testdata/daemonsets/override-labels-and-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/patch-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/shutdown-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/volumes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-concurrency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-extra-args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-image-pull-secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-name.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-node-selector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions ...infrastructure/kubernetes/proxy/testdata/daemonsets/with-topology-spread-constraints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/component-level.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions ...rnal/infrastructure/kubernetes/proxy/testdata/deployments/custom_with_initcontainers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/disable-prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,12 @@ spec:
name: EnvoyHTTPSPort
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
4 changes: 2 additions & 2 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/extension-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,12 @@ spec:
name: metrics
protocol: TCP
readinessProbe:
failureThreshold: 3
failureThreshold: 1
httpGet:
path: /ready
port: 19001
scheme: HTTP
periodSeconds: 10
periodSeconds: 5
successThreshold: 1
timeoutSeconds: 1
resources:
Expand Down
Loading