Skip to content

feat: adds support for ratelimit metrics monitoring in grafana#4083

Merged
zirain merged 2 commits into
envoyproxy:mainfrom
mdsahiloss:grafana-dashboard
Sep 28, 2024
Merged

feat: adds support for ratelimit metrics monitoring in grafana#4083
zirain merged 2 commits into
envoyproxy:mainfrom
mdsahiloss:grafana-dashboard

Conversation

@mdsahiloss
Copy link
Copy Markdown
Contributor

@mdsahiloss mdsahiloss commented Aug 19, 2024

What type of PR is this?

feat: adds support for ratelimit metrics monitoring in grafana

What this PR does / why we need it:
Adds new visualization panels in grafana dashboard Envoy Gateway Global

Which issue(s) this PR fixes:

Fixes #3871

This PR depends on #4073

@mdsahiloss mdsahiloss requested a review from a team as a code owner August 19, 2024 16:41
@mdsahiloss
Copy link
Copy Markdown
Contributor Author

mdsahiloss commented Aug 19, 2024

@arkodg @zirain Please review this PR, Let me know if any more changes need to be made :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (a9f740a) to head (fc37cb1).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   66.01%   65.98%   -0.03%     
==========================================
  Files         197      197              
  Lines       23971    23971              
==========================================
- Hits        15825    15818       -7     
- Misses       7021     7026       +5     
- Partials     1125     1127       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg reviewed Aug 19, 2024
View reviewed changes
Comment thread charts/gateway-addons-helm/dashboards/envoy-gateway-global.json Outdated
Copy link
Copy Markdown
Contributor

@arkodg arkodg Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a variable and read from a drop down ?

Copy link
Copy Markdown
Contributor Author

@mdsahiloss mdsahiloss Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a variable DefaultDomain for domain value default/eg/http and kept key1 & key2 as it is because I think key1 & key2 values change according to HTTPRoute configuration and other configs.

Copy link
Copy Markdown
Contributor Author

@mdsahiloss mdsahiloss Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkodg Should I create variables for key1 & key2 as well ?

arkodg
arkodg reviewed Aug 19, 2024
View reviewed changes
Comment thread charts/gateway-addons-helm/dashboards/envoy-gateway-global.json Outdated
Copy link
Copy Markdown
Contributor

@arkodg arkodg Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Copy Markdown
Contributor Author

@mdsahiloss mdsahiloss Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@mdsahiloss mdsahiloss force-pushed the grafana-dashboard branch 2 times, most recently from 3dd81d3 to b2ad4a3 Compare August 21, 2024 07:28
@mdsahiloss mdsahiloss requested a review from arkodg August 21, 2024 07:29
@mdsahiloss mdsahiloss force-pushed the grafana-dashboard branch 2 times, most recently from efa81ab to fff1a75 Compare August 25, 2024 17:56
shawnh2
shawnh2 reviewed Aug 27, 2024
View reviewed changes
Comment thread charts/gateway-addons-helm/dashboards/envoy-gateway-global.json Outdated
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right place for the global ratelimit dashboard, can you move this into a new dashboard, probably with name global-ratelimit.json ?

Copy link
Copy Markdown
Contributor Author

@mdsahiloss mdsahiloss Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍🏽

@mdsahiloss
feat: adds support for ratelimit metrics monitoring in grafana
dc545d6 
Signed-off-by: MdSahil-oss <mohdssahil1@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 27, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Sep 27, 2024
@zirain zirain requested a review from shawnh2 September 27, 2024 12:23
@github-actions github-actions Bot removed the stale label Sep 27, 2024
shawnh2
shawnh2 approved these changes Sep 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looking Good ! Thanks for adding this!

@zirain zirain merged commit cbd92e2 into envoyproxy:main Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

@arkodg arkodg Awaiting requested review from arkodg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metrics from the Ratelimiting service in the Grafana dashboard

4 participants

@mdsahiloss @zirain @arkodg @shawnh2