Skip to content

Use BackendCluster to represent OIDCProvider#4227

Merged
zhaohuabing merged 43 commits into
envoyproxy:mainfrom
zhaohuabing:oidc-backendcluster
Oct 18, 2024
Merged

Use BackendCluster to represent OIDCProvider#4227
zhaohuabing merged 43 commits into
envoyproxy:mainfrom
zhaohuabing:oidc-backendcluster

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Sep 12, 2024

Using BackendCluster to represent OIDCProvider allows users to customize backend connection settings for OIDC providers, such as retry policy and tls setting.

Fix: #3178

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner September 12, 2024 15:52
@zhaohuabing zhaohuabing marked this pull request as draft September 12, 2024 15:52
@zhaohuabing zhaohuabing changed the title use BackendCluster to represent OIDCProvider Use BackendCluster to represent OIDCProvider Sep 12, 2024
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.20567% with 53 lines in your changes missing coverage. Please review.

Project coverage is 65.65%. Comparing base (7293b6c) to head (977adb3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/oidc.go 69.36% 23 Missing and 11 partials ⚠️
internal/gatewayapi/securitypolicy.go 80.76% 10 Missing and 5 partials ⚠️
internal/gatewayapi/ext_service.go 91.66% 2 Missing and 1 partial ⚠️
internal/gatewayapi/envoyextensionpolicy.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4227      +/-   ##
==========================================
+ Coverage   65.56%   65.65%   +0.08%     
==========================================
  Files         200      200              
  Lines       30268    30362      +94     
==========================================
+ Hits        19845    19933      +88     
- Misses       9281     9285       +4     
- Partials     1142     1144       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review September 15, 2024 08:11
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Comment thread api/v1alpha1/oidc_types.go
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing and others added 8 commits October 8, 2024 17:43
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from arkodg October 8, 2024 11:40
Comment thread internal/xds/translator/oidc.go
@zhaohuabing zhaohuabing requested a review from arkodg October 11, 2024 12:17
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 17, 2024 23:53
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 17, 2024

thanks @zhaohuabing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent 'OAuth Flow Failure' potentially caused by reuse of old connections in pool

3 participants