Skip to content

api: Wasm code source TLS configuration#4492

Merged
zhaohuabing merged 2 commits into
envoyproxy:mainfrom
zhaohuabing:wasm-tls
Apr 10, 2025
Merged

api: Wasm code source TLS configuration#4492
zhaohuabing merged 2 commits into
envoyproxy:mainfrom
zhaohuabing:wasm-tls

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

API for: #4466

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 21, 2024 07:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (f880731) to head (cc36679).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4492      +/-   ##
==========================================
+ Coverage   65.25%   65.32%   +0.06%     
==========================================
  Files         213      213              
  Lines       34132    34108      -24     
==========================================
+ Hits        22273    22280       +7     
+ Misses      10521    10492      -29     
+ Partials     1338     1336       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain
Copy link
Copy Markdown
Member

zirain commented Oct 21, 2024

I think we still need allow insecure registry in some cause, e.g. dev, localhost?

@zhaohuabing
Copy link
Copy Markdown
Member Author

zhaohuabing commented Oct 22, 2024

I think we still need allow insecure registry in some cause, e.g. dev, localhost?

We should avoid insecure as it poses potential security risks. A self-signed CA can be used for testing and development purposes.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Dec 25, 2024
Comment thread api/v1alpha1/wasm_types.go Outdated
@github-actions github-actions Bot removed the stale label Jan 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Feb 12, 2025
@zhaohuabing zhaohuabing changed the title API for Wasm code source TLS configuration api: Wasm code source TLS configuration Feb 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Comment thread api/v1alpha1/wasm_types.go
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from arkodg April 5, 2025 18:56
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team April 9, 2025 17:55
@zhaohuabing zhaohuabing merged commit 0019667 into envoyproxy:main Apr 10, 2025
28 checks passed
@zhaohuabing zhaohuabing deleted the wasm-tls branch April 10, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants