enable rate limit for month and year

[rpahli]

What type of PR is this?

adds the option to set rate limit unit to Month and Year which was introduced with envoy 1.25.

What this PR does / why we need it:

Which issue(s) this PR fixes:

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (544bd9c) to head (d123cb6).
Report is 132 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/backendtrafficpolicy.go	0.00%	4 Missing ⚠️
internal/xds/translator/local_ratelimit.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4495      +/-   ##
==========================================
- Coverage   65.95%   65.74%   -0.21%     
==========================================
  Files         203      210       +7     
  Lines       31154    31524     +370     
==========================================
+ Hits        20547    20726     +179     
- Misses       9420     9602     +182     
- Partials     1187     1196       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[arkodg]

thanks for the submitting the PR @rpahli !

you probably need a few more changes

• in ratelimit service https://github.com/envoyproxy/ratelimit/blob/28b1629a21e885bdd2b527d6a1c1de8483dc47d4/src/utils/utilities.go#L19
• https://github.com/envoyproxy/ratelimit/blob/28b1629a21e885bdd2b527d6a1c1de8483dc47d4/api/ratelimit/config/ratelimit/v3/rls_conf.proto#L78

can you also add a test case in https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/in/ratelimit-config / https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata/out/ratelimit-config

and an addition to https://github.com/envoyproxy/gateway/blob/main/test/e2e/tests/ratelimit.go to make sure it works e2e

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[rpahli]

unstale

[arkodg]

@rpahli looks like changes were committed to ratelimit and should be okay to introduce the Changes here

[arkodg]

LGTM thanks !

[cnvergence]

/retest

[arkodg]

@rpahli can you address the lint errors

tools/bin/yamllint --config-file=tools/linter/yamllint/.yamllint $(git ls-files :*.yml :*.yaml | xargs -L1 dirname | sort -u) 
./internal/xds/translator/testdata/in/ratelimit-config/month-year-rule.yaml
  Error: 34:11 [indentation] wrong indentation: expected 8 but found 10
  Error: 35:15 [indentation] wrong indentation: expected 12 but found 14
  Error: 45:7 [indentation] wrong indentation: expected 4 but found 6
  Error: 46:11 [indentation] wrong indentation: expected 8 but found 10

[arkodg]

@rpahli you'll also need to run 'make generate' && 'make manifests' and commit those changes

[arkodg]

@rpahli tests are failing, can you look into it

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[commoddity]

@rpahli Thanks for creating this PR.

I've been looking into the failing tests and it appears that the issue stems from the fact that envoyproxy/go-control-plane is not yet updated with the required version of the proto-generated Go file from envoyproxy/ratelimit:

Does not contain MONTH and YEAR:

• https://github.com/envoyproxy/go-control-plane/blob/main/ratelimit/config/ratelimit/v3/rls_conf.pb.go

Does contain MONTH and YEAR:

• https://github.com/envoyproxy/ratelimit/blob/main/api/ratelimit/config/ratelimit/v3/rls_conf.proto

[zhaohuabing]

@rpahli envoyproxy/go-control-plane#1223 should unblock us.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[zhaohuabing]

@rpahli This PR is now unblocked by envoyproxy/go-control-plane#1223. Could you please proceed when you get a chance?

[Olshansk]

@rpahli Any blocker/reason we don't merge this PR?

[arkodg]

if anyone want to take this PR forward, please go ahead and raise a new PR with the same content and lint & test fixed

[commoddity]

if anyone want to take this PR forward, please go ahead and raise a new PR with the same content and lint & test fixed

@arkodg I've opened a new PR here that updates the version of github.com/envoyproxy/go-control-plane/ratelimit to include the MONTH and YEAR options: PR #6715: Rate Limiter: Enable rate limit for month and year

Linter and all tests are passing locally.

Looks like workflows just need approval to run: https://github.com/envoyproxy/gateway/actions/runs/16774366797

[commoddity]

This was resolved with #6715 being merged. Recommend we close this PR now: @arkodg @rpahli