fix: decouple gateway status updates from the reconciler by zhaohuabing · Pull Request #4767 · envoyproxy/gateway

zhaohuabing · 2024-11-22T07:50:15Z

Fixes: #4845
Release Note: Yes

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

codecov · 2024-11-22T08:22:21Z

Codecov Report

Attention: Patch coverage is 76.82927% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (9b60a67) to head (fb00fb0).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/provider/kubernetes/controller.go	57.14%	9 Missing ⚠️
internal/provider/kubernetes/status.go	71.42%	4 Missing and 2 partials ⚠️
internal/infrastructure/runner/runner.go	0.00%	2 Missing ⚠️
internal/provider/kubernetes/kubernetes.go	93.33%	0 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4767      +/-   ##
==========================================
+ Coverage   66.24%   66.31%   +0.06%     
==========================================
  Files         209      209              
  Lines       31922    31950      +28     
==========================================
+ Hits        21148    21188      +40     
+ Misses       9523     9512      -11     
+ Partials     1251     1250       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

arkodg · 2024-11-22T19:20:46Z

were we deadlocking ?

zhaohuabing · 2024-11-23T02:04:44Z

were we deadlocking ?

It's my suspicion. I can't reproduce this issue, but based on the description of #4685, it seems that the reconciler has been blocked - the pods changes haven't been propogated to the Envoy through xDS, and the only PR in v1.1.3 that might cause blocking is #4337 .

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

…ocking

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zirain · 2024-12-12T08:31:46Z

 	Logger logging.Logger
 	// Elected chan is used to signal what a leader is elected
-	Elected chan struct{}
+	Elected *sync.WaitGroup


why we need a pointer here?

internal/infrastructure/runner/runner.go:35:25: copylocks: literal copies lock value from *cfg: github.com/envoyproxy/gateway/internal/infrastructure/runner.Config contains github.com/envoyproxy/gateway/internal/envoygateway/config.Server contains sync.WaitGroup contains sync.noCopy (govet) return &Runner{Config: *cfg}

zhaohuabing · 2024-12-12T09:01:03Z

Verified with #4904.

arkodg

LGTM thanks !

…4767) * decoup gateway status update Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * decoup gatewayclass status update Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * add comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix test Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * revert gateway api runner Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * update address and programming status Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * Revert "update address and programming status" This reverts commit bf3d07e. * avoid overriding the gateway status from Gateway API translator Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * only subscribe to status updates upon acquiring leadership Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comment Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor wording Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * minor change Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * release note Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> (cherry picked from commit c1ff135) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing requested a review from a team as a code owner November 22, 2024 07:50

zhaohuabing changed the title ~~decoup gateway status update~~ fix: decoup gateway status update Nov 22, 2024

zhaohuabing mentioned this pull request Nov 22, 2024

Fix: frequent 503 errors when connecting to a Service experiencing high Pod churn #4754

Merged

decoup gateway status update

8c84649

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the fix-gateway-status-blocking branch from 1797785 to 8c84649 Compare November 22, 2024 08:15

zhaohuabing mentioned this pull request Nov 22, 2024

503s and _No_route_to_host errors due to routing to non-existent Endpoints #4685

Closed

decoup gatewayclass status update

8c9d33e

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing changed the title ~~fix: decoup gateway status update~~ fix: decoup gateway status updates from the reconciler Nov 22, 2024

arkodg reviewed Nov 22, 2024

View reviewed changes

Comment thread internal/provider/kubernetes/status.go

arkodg reviewed Nov 22, 2024

View reviewed changes

Comment thread internal/provider/kubernetes/predicates.go Outdated

fix test

fc97316

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the fix-gateway-status-blocking branch from 2b2535b to 8323c0f Compare November 23, 2024 07:20

add comment

bccc70c

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the fix-gateway-status-blocking branch 2 times, most recently from 91fe885 to bb391aa Compare November 23, 2024 07:37

fix test

7a4c51e

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the fix-gateway-status-blocking branch from bb391aa to 7a4c51e Compare November 23, 2024 07:49

zhaohuabing marked this pull request as draft November 23, 2024 08:32

zhaohuabing force-pushed the fix-gateway-status-blocking branch from d948846 to 0a1f8f2 Compare November 23, 2024 11:47

fix test

e406088

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the fix-gateway-status-blocking branch from 0a1f8f2 to e406088 Compare November 23, 2024 12:00

zhaohuabing marked this pull request as ready for review November 23, 2024 12:21

zhaohuabing requested a review from arkodg November 23, 2024 12:21

zhaohuabing commented Nov 24, 2024

View reviewed changes

Comment thread internal/provider/kubernetes/predicates.go

arkodg reviewed Nov 25, 2024

View reviewed changes

Comment thread internal/provider/kubernetes/predicates.go Outdated

arkodg reviewed Nov 25, 2024

View reviewed changes

Comment thread internal/gatewayapi/runner/runner.go Outdated

revert gateway api runner

163cf5c

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing added 4 commits December 11, 2024 02:16

minor wording

3d20090

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

only subscribe to status updates upon acquiring leadership

c7b7f44

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

fix lint

be6df9a

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

Merge remote-tracking branch 'origin/main' into fix-gateway-status-bl…

5448863

…ocking

zhaohuabing requested a review from arkodg December 11, 2024 03:30

alexwo mentioned this pull request Dec 11, 2024

feat: data plane & envoyproxy resilience test suite #4862

Merged

zhaohuabing added 2 commits December 11, 2024 17:16

Merge branch 'main' into fix-gateway-status-blocking

3fc0ec4

minor wording

9aa5c7c

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing mentioned this pull request Dec 11, 2024

OIDC filter randomly failing in v1.2 due to missing information in token request #4718

Closed

arkodg reviewed Dec 11, 2024

View reviewed changes

Comment thread internal/provider/kubernetes/controller.go Outdated

arkodg changed the title ~~fix: decoup gateway status updates from the reconciler~~ fix: decouple gateway status updates from the reconciler Dec 11, 2024

zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Dec 12, 2024

test ResilienceTests with envoyproxy#4767

7be3bc2

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing added 6 commits December 12, 2024 06:54

address comment

75dcfbd

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

address comment

ba06d2b

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

minor wording

d77aa7d

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

fix lint

99a2910

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

Merge branch 'main' into fix-gateway-status-blocking

6ec2c6d

minor change

f36b72f

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing requested a review from arkodg December 12, 2024 07:25

release note

fb00fb0

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zirain reviewed Dec 12, 2024

View reviewed changes

arkodg approved these changes Dec 12, 2024

View reviewed changes

arkodg requested review from a team and guydc December 12, 2024 18:25

guydc approved these changes Dec 12, 2024

View reviewed changes

arkodg merged commit c1ff135 into envoyproxy:main Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: decouple gateway status updates from the reconciler#4767

fix: decouple gateway status updates from the reconciler#4767
arkodg merged 27 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-gateway-status-blocking

zhaohuabing commented Nov 22, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Nov 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

arkodg commented Nov 22, 2024

Uh oh!

Uh oh!

zhaohuabing commented Nov 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zirain Dec 12, 2024

Uh oh!

zhaohuabing Dec 12, 2024 •

edited

Loading

Uh oh!

zhaohuabing commented Dec 12, 2024

Uh oh!

arkodg left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zhaohuabing commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

arkodg commented Nov 22, 2024

Uh oh!

Uh oh!

zhaohuabing commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zirain Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

zhaohuabing Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhaohuabing commented Dec 12, 2024

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhaohuabing commented Nov 22, 2024 •

edited

Loading

codecov Bot commented Nov 22, 2024 •

edited

Loading

zhaohuabing commented Nov 23, 2024 •

edited

Loading

zhaohuabing Dec 12, 2024 •

edited

Loading