api: ext-proc attributes#4794
Merged
guydc merged 2 commits intoenvoyproxy:mainfrom Nov 28, 2024
Merged
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
==========================================
- Coverage 65.61% 65.60% -0.02%
==========================================
Files 211 211
Lines 31989 31989
==========================================
- Hits 20991 20987 -4
- Misses 9760 9762 +2
- Partials 1238 1240 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
curious what happens when something like |
Contributor
Author
Yes, it's just ignored and not passed. Config is still accepted by the proxy. |
zirain
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Following the discussion at KubeCon NA : https://docs.google.com/document/d/1PS5xLA0IDbj6McHIXXhShn51Zq37WvuistaidBPeHoE/edit?tab=t.0
Scope and Motivation
This API will allow users to define which attributes are sent to the external processor as context for requests/responses.
Attributes provide HTTP extensions with additional context (e.g. TCP, TLS and XDS attributes) that can be relevant inputs for the extension logic.
Comparison to other extension options
Many Envoy extensions are inherently capable of interaction with context attributes:
For out-of-process extensions like ext-proc, Envoy must be explicitly configured to allow access to attributes and and define the scope of access. With the increase in ext-proc use cases, such as the llm-instance-gateway, envoy-ai-gateway and externally-deployed WAFs, there is a greater need to provide extension with context.
Security Considerations
Most attributes are scoped to the current connection or stream by their prefix (
connection.*,request.*,response.*), with the exception ofxds.*attributes such asxds.listener_metadata,xds.upstream_host_metadata,xds.nodeand generic metadata and filter state access attributes.Related Work
Untypedmetadata support in ExtProc #4160Release Notes: Yes