fix benchmark test

[zhaohuabing]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.31%. Comparing base (b924e6a) to head (0bd9b16).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5478      +/-   ##
==========================================
+ Coverage   65.27%   65.31%   +0.03%     
==========================================
  Files         213      213              
  Lines       33915    33990      +75     
==========================================
+ Hits        22139    22199      +60     
- Misses      10443    10466      +23     
+ Partials     1333     1325       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zhaohuabing]

Looks like older version doesn't work.

[arkodg]

@zhaohuabing you'll need to use something older like 684a8af7efec1536a4a1fdc6cf46a5f86b65aaae

[zirain]

@zhaohuabing you'll need to use something older like 684a8af7efec1536a4a1fdc6cf46a5f86b65aaae

it's 3 years ago.

[zhaohuabing]

@zhaohuabing you'll need to use something older like 684a8af7efec1536a4a1fdc6cf46a5f86b65aaae

it's 3 years ago.

I tried another one and it didn't work.

They haven't pushed tagged images for a long time, only the latest tag is available.

[zhaohuabing]

684a8af7efec1536a4a1fdc6cf46a5f86b65aaae doesn't work either.

[arkodg]

Ah let's temporarily disable benchmark test until it's fixed upstream?

[zirain]

we can try to build the image with following dockerfile as a workaround.

FROM envoyproxy/nighthawk-dev:latest AS source

FROM ubuntu:22.04@sha256:0e5e4a57c2499249aafc3b40fcd541e9a456aab7296681a3994d631587203f97

RUN apt-get update && apt-get install \
        autoconf \
        automake \
        cmake \
        curl \
        libtool \
        make \
        ninja-build \
        patch \
        python3-pip \
        unzip \
        virtualenv -y

COPY --from=source /usr/local/bin/nighthawk_client /usr/local/bin/nighthawk_client
COPY --from=source /usr/local/bin/nighthawk_test_server /usr/local/bin/nighthawk_test_server
COPY --from=source /usr/local/bin/nighthawk_output_transform /usr/local/bin/nighthawk_output_transform
COPY --from=source /usr/local/bin/nighthawk_service /usr/local/bin/nighthawk_service
COPY --from=source /usr/local/bin/nighthawk_adaptive_load_client /usr/local/bin/nighthawk_adaptive_load_client
COPY --from=source /etc/envoy/envoy.yaml /etc/envoy/envoy.yaml

# Ports for nighthawk_test_server, see default-config.yaml
EXPOSE 10001
EXPOSE 10080
# The default port for nighthawk_service
EXPOSE 8443

CMD ["-c", "/etc/envoy/envoy.yaml"]

[arkodg]

@zirain can't we update the dockerfile upstream?

[zirain]

envoyproxy/nighthawk#1314 someone is working on it, but not sure about the ETA.
There are 2 options:

1. build with static
2. change the base image

[zhaohuabing]

Use a temporary docker image zhaohuabing/nighthawk:latest to unblock the CI.
We can switch back to the official nighthawk image after envoyproxy/nighthawk#1312 is solved.

[zirain]

we didn't need this after envoyproxy/nighthawk#1315

[zhaohuabing]

envoyproxy/nighthawk#1315 has been merged. Close this PR.