Skip to content

feat(helm) Make Gateway API CRDs a pre-req#5614

Closed
nissessenap wants to merge 1 commit intoenvoyproxy:mainfrom
nissessenap:seperate_gatewayapi-crds
Closed

feat(helm) Make Gateway API CRDs a pre-req#5614
nissessenap wants to merge 1 commit intoenvoyproxy:mainfrom
nissessenap:seperate_gatewayapi-crds

Conversation

@nissessenap
Copy link
Copy Markdown
Contributor

What type of PR is this?
feature

What this PR does / why we need it:
Support upgrading EG CRDs and make it possible to install EG in a Kubernetes cluster that already got Gateway API CRDs installed.

Which issue(s) this PR fixes:

Fixes #4001

Release Notes: Yes/No

- make EG CRDs to be a part of the release as a zip.
Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
@nissessenap nissessenap requested a review from a team as a code owner March 25, 2025 21:15
@nissessenap
Copy link
Copy Markdown
Contributor Author

I'm a bit too tired, so I just leave this here as a start.

I need to update the quickstart docs and probably some others install instructions. My updates should be in site/content/en/latest if I understand correctly.

Since this is a breaking change, we should do some kind of release note, but I can't find where to write it.
Or is it just a description in the PR?

Another issues that the helm chart follow the version of EG, so it's kind of hard to make a breaking change of the helm chart since versions won't be bumped.

This is kind of normal in the Kubernets world, sadly I think the helm users just have to live with it.... We could of course try to fix it, but it's a pain to manage separate versions, that is why everyone does it this way.

Would love to get any other points on what I have missed, there has been some discussion around how to solve this in #4001, #3094, #5609, and I wanted to move this forward since this is a blocker for me. So I hope a PR will make the issue move forward.

Install Kubernetes Gateway API CRDs before installing this chart. You can install the CRDs using the following command:

``` shell
kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/{{ env "GATEWAY_API_VERSION" }}/experimental-install.yaml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this file into charts and make it as an option? That would be better for user.

@nissessenap
Copy link
Copy Markdown
Contributor Author

This will be solved in #5616 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRDs upgrade support

2 participants