Skip to content

feat: impl dynamic resolver backend type#5725

Merged
zhaohuabing merged 3 commits into
envoyproxy:mainfrom
zhaohuabing:dynamic-resolver
Apr 30, 2025
Merged

feat: impl dynamic resolver backend type#5725
zhaohuabing merged 3 commits into
envoyproxy:mainfrom
zhaohuabing:dynamic-resolver

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Apr 14, 2025 •
edited
Loading

This PR implements the dynamic resolver Backend type.

To keep the scope managed and make this easier to review, this PR only modifies the HTTPRoute. Follow-up PRs will extend dynamic resolver for GRPCRoute, TLSRoute, TCPRoute, and UDPRoute.

Impl: #3560
Release Notes: Yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner April 14, 2025 04:21
@zhaohuabing zhaohuabing marked this pull request as draft April 14, 2025 04:21
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver branch 12 times, most recently from 1fd8e40 to a6e6862 Compare April 14, 2025 09:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.58209% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.37%. Comparing base (7c88e66) to head (00affe4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 87.77% 8 Missing and 3 partials ⚠️
internal/gatewayapi/backend.go 25.00% 5 Missing and 1 partial ⚠️
internal/ir/xds.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5725      +/-   ##
==========================================
+ Coverage   65.32%   65.37%   +0.04%     
==========================================
  Files         222      222              
  Lines       35459    35532      +73     
==========================================
+ Hits        23164    23228      +64     
- Misses      10859    10868       +9     
  Partials     1436     1436

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing zhaohuabing force-pushed the dynamic-resolver branch 2 times, most recently from f9fe173 to 48ee39a Compare April 14, 2025 11:26
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/cmd/egctl/testdata/translate/out/rejected-http-route.route.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/backendtlspolicy-multiple-targets.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/backendtlspolicy-serviceimport-target.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/backendtrafficpolicy-status-conditions.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/backendtrafficpolicy-with-timeout-targetrefs.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/clienttrafficpolicy-http10.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/custom-filter-order.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/envoyextensionpolicy-status-conditions.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/envoyextensionpolicy-with-wasm-targetrefs.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/envoyproxy-accesslog-types.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/gateway-http-listener-with-hostname-intersection.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/httproute-with-multiple-gateways-from-different-ns.in.yaml Outdated
zhaohuabing
zhaohuabing commented Apr 14, 2025
View reviewed changes
Comment thread internal/gatewayapi/testdata/httproute-with-multiple-invalid-rules.out.yaml Outdated
@zhaohuabing zhaohuabing marked this pull request as ready for review April 15, 2025 10:33
@zhaohuabing zhaohuabing requested a review from arkodg April 15, 2025 10:33
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver branch 4 times, most recently from 0e5813d to 149b1ee Compare April 15, 2025 12:24
@zhaohuabing zhaohuabing mentioned this pull request Apr 15, 2025
Merged
@arkodg

This comment was marked as outdated.

Sign in to view
@zhaohuabing zhaohuabing marked this pull request as draft April 17, 2025 00:53
@zhaohuabing

This comment was marked as outdated.

Sign in to view
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver branch 2 times, most recently from 6afe595 to 520d922 Compare April 24, 2025 02:50
@zhaohuabing
impl dynamic resolver backend type
2d444ea 
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

fix test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

add comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

add e2e test

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

Update internal/gatewayapi/backend.go

Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

fix reason

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

fix tests

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

improve status messages

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review April 24, 2025 03:03
@zhaohuabing zhaohuabing requested review from a team April 24, 2025 03:03
@arkodg arkodg added this to the v1.4.0-rc.1 milestone Apr 30, 2025
arkodg
arkodg previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team April 30, 2025 00:27
@zhaohuabing zhaohuabing requested a review from arkodg April 30, 2025 02:13
@zhaohuabing zhaohuabing merged commit c3d89dc into envoyproxy:main Apr 30, 2025
23 of 24 checks passed
@zhaohuabing zhaohuabing deleted the dynamic-resolver branch April 30, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@zhaohuabing @arkodg @zirain