Skip to content

feat: impl GEP-3388 (Retry Budget)#5790

Closed
zirain wants to merge 4 commits into
envoyproxy:mainfrom
zirain:gep-3388
Closed

feat: impl GEP-3388 (Retry Budget)#5790
zirain wants to merge 4 commits into
envoyproxy:mainfrom
zirain:gep-3388

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 22, 2025

xref: #5298

@zirain zirain requested a review from a team as a code owner April 22, 2025 13:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 51.45228% with 117 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (36651e7) to head (4c5e92c).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/xbackendtrafficpolicy.go 54.76% 44 Missing and 13 partials ⚠️
internal/provider/kubernetes/controller.go 21.42% 30 Missing and 3 partials ⚠️
internal/gatewayapi/runner/runner.go 7.69% 22 Missing and 2 partials ⚠️
internal/xds/utils/utils.go 76.92% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (51.45%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5790      +/-   ##
==========================================
- Coverage   70.52%   70.45%   -0.07%     
==========================================
  Files         219      220       +1     
  Lines       36342    36570     +228     
==========================================
+ Hits        25629    25766     +137     
- Misses       9192     9266      +74     
- Partials     1521     1538      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain zirain force-pushed the gep-3388 branch 2 times, most recently from f067c42 to 23d0e5a Compare April 24, 2025 03:08
@zirain zirain added this to the Backlog milestone Apr 29, 2025
@zirain zirain force-pushed the gep-3388 branch 2 times, most recently from cb18d7f to 885cfa1 Compare May 12, 2025 00:39
@zirain zirain modified the milestones: Backlog, v1.5.0-rc.1 Release May 20, 2025
@zirain zirain force-pushed the gep-3388 branch 3 times, most recently from ae6c918 to 8b94f8c Compare May 21, 2025 06:31
Signed-off-by: zirain <zirain2009@gmail.com>
@@ -0,0 +1,50 @@
gateways:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted?

Comment thread internal/gatewayapi/testdata/xbackendtrafficpolicy-invalid-retry-budget.out.yaml Outdated
zirain added 2 commits May 22, 2025 16:57
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member

@zirain Let's hold this until #6153 is fixed.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain closed this May 28, 2025
@zirain
Copy link
Copy Markdown
Member Author

zirain commented May 28, 2025

close this now to unblock anyone who interest in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants