chart: adding extraVolumeMounts and extraVolumes fields to be mapped on the pods as volumes

[nnicora]

What type of PR is this?

• chart: add support for external volumes and volumeMounts

What this PR does / why we need it:
Whenever wants the gateway to communicate with the extensions over the unix socket, the gateway have to be configured with the right existing socket directory path which should be mounted to the deployment.

Release Notes: No

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (8d6d423) to head (f025ab1).
⚠️ Report is 1091 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5853      +/-   ##
==========================================
+ Coverage   70.60%   70.66%   +0.05%     
==========================================
  Files         220      220              
  Lines       36829    36829              
==========================================
+ Hits        26003    26025      +22     
+ Misses       9293     9275      -18     
+ Partials     1533     1529       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zirain]

I think we didn't the extra prefix, WDYT?
cc @envoyproxy/gateway-maintainers

[arkodg]

if we dont do the extra then we will need to expose the internal volumeMount here

[nnicora]

@envoyproxy/gateway-maintainers

Any updates on this PR ?

[arkodg]

hey @nnicora is there any prior art for this
the decision to be made here is

1. extraVolumeMounts that appends to existing mounts
   vs
2. volumeMounts definition that moves the existing values from the template into the helm values section

[arkodg]

LGTM thanks !

[arkodg]

@nnicora can you sign your commit and force push ?

[nnicora]

@nnicora can you sign your commit and force push ?

Done!

[zirain]

can you fix DCO?

[arkodg]

some tests are failing @nnicora, also can you add a test in https://github.com/envoyproxy/gateway/tree/main/test/helm

[arkodg]

@nnicora can you address the comments ?

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

[zirain]

let's close this for now, feel free to reopen.