Skip to content

feat: enable GatewayInfrastructure in GatewayNamespaceMode#5996

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:conformace/GatewayInfrastructure
May 31, 2025
Merged

feat: enable GatewayInfrastructure in GatewayNamespaceMode#5996
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:conformace/GatewayInfrastructure

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented May 10, 2025

xref: #6000

@zirain

This comment was marked as outdated.

@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from 36a989c to 8b7b7e4 Compare May 11, 2025 00:45
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.48%. Comparing base (250cb10) to head (3a8aa06).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...frastructure/kubernetes/proxy/resource_provider.go 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5996      +/-   ##
==========================================
- Coverage   70.48%   70.48%   -0.01%     
==========================================
  Files         220      220              
  Lines       36593    36594       +1     
==========================================
- Hits        25794    25793       -1     
- Misses       9275     9277       +2     
  Partials     1524     1524              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/infrastructure/kubernetes/proxy/resource_provider.go Outdated
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch 2 times, most recently from 6e573a4 to ede15d7 Compare May 12, 2025 01:59
@zirain zirain marked this pull request as ready for review May 12, 2025 02:49
@zirain zirain requested a review from a team as a code owner May 12, 2025 02:49
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from ede15d7 to bfb894e Compare May 12, 2025 02:49
@zirain zirain added this to the Backlog milestone May 12, 2025
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from bfb894e to a052ba1 Compare May 19, 2025 10:40
@zirain zirain modified the milestones: Backlog, v1.5.0-rc.1 Release May 19, 2025
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from a052ba1 to f991124 Compare May 19, 2025 10:45
@zirain zirain changed the title conformace: enable GatewayInfrastructure in GatewayNamespaceMode feat: enable GatewayInfrastructure in GatewayNamespaceMode May 19, 2025
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from f991124 to 1a5cfea Compare May 21, 2025 03:03
Comment thread internal/infrastructure/kubernetes/proxy/resource_provider.go Outdated
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from 1a5cfea to 4ebd48c Compare May 28, 2025 05:36
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the core change.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the conformace/GatewayInfrastructure branch from 4ebd48c to 3a8aa06 Compare May 28, 2025 06:07
@zirain zirain requested a review from arkodg May 28, 2025 06:10
Comment thread internal/infrastructure/kubernetes/proxy/resource_provider.go
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit dfce6f4 into envoyproxy:main May 31, 2025
44 of 45 checks passed
@zirain zirain deleted the conformace/GatewayInfrastructure branch May 31, 2025 06:55
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jun 3, 2025

@arkodg do we really want land this into v1.4?

If so, we also need #6132.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jun 3, 2025

Thanks added the label for #6132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants