Skip to content

fix tls test#6032

Closed
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
zirain:e2e/tls-test
Closed

fix tls test#6032
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
zirain:e2e/tls-test

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented May 13, 2025

fixes: #6029

@zirain zirain requested a review from a team as a code owner May 13, 2025 09:42
Comment thread test/e2e/base/manifests.yaml Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this's not used anywhere

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used separeated EnvoyConfig instead of patch the shared one(proxy-config).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.45%. Comparing base (8455177) to head (5159956).
⚠️ Report is 1186 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6032      +/-   ##
==========================================
- Coverage   70.45%   70.45%   -0.01%     
==========================================
  Files         217      217              
  Lines       36038    36038              
==========================================
- Hits        25392    25390       -2     
- Misses       9140     9143       +3     
+ Partials     1506     1505       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a new service name instead of overriding the one with same name in manifests.

@zirain zirain marked this pull request as draft May 13, 2025 10:11
zirain added 2 commits May 13, 2025 18:37
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain closed this May 13, 2025
@zirain zirain deleted the e2e/tls-test branch June 24, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant