fix tls test#6032
Closed
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Conversation
zirain
commented
May 13, 2025
Member
Author
There was a problem hiding this comment.
nit: this's not used anywhere
zirain
commented
May 13, 2025
Member
Author
There was a problem hiding this comment.
used separeated EnvoyConfig instead of patch the shared one(proxy-config).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6032 +/- ##
==========================================
- Coverage 70.45% 70.45% -0.01%
==========================================
Files 217 217
Lines 36038 36038
==========================================
- Hits 25392 25390 -2
- Misses 9140 9143 +3
+ Partials 1506 1505 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
commented
May 13, 2025
Member
Author
There was a problem hiding this comment.
use a new service name instead of overriding the one with same name in manifests.
Signed-off-by: zirain <zirain2009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6029