Skip to content

[release/v1.4] fix: custom controller namespace refs in gateway namespace mode#6067

Merged
zirain merged 1 commit intoenvoyproxy:release/v1.4from
cnvergence:rel-1.4-fix-ctrl-ns
May 14, 2025
Merged

[release/v1.4] fix: custom controller namespace refs in gateway namespace mode#6067
zirain merged 1 commit intoenvoyproxy:release/v1.4from
cnvergence:rel-1.4-fix-ctrl-ns

Conversation

@cnvergence
Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

cherry-pick of #6065

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@cnvergence cnvergence requested a review from a team as a code owner May 14, 2025 11:27
@cnvergence
Copy link
Copy Markdown
Member Author

/retest

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (720f98d) to head (0c252a7).
Report is 1 commits behind head on release/v1.4.

Files with missing lines Patch % Lines
...ternal/infrastructure/kubernetes/infra_resource.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.4    #6067      +/-   ##
================================================
- Coverage         70.43%   70.41%   -0.02%     
================================================
  Files               217      217              
  Lines             36171    36171              
================================================
- Hits              25476    25471       -5     
- Misses             9176     9180       +4     
- Partials           1519     1520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cnvergence
Copy link
Copy Markdown
Member Author

/retest

@zirain zirain merged commit 0cd14e9 into envoyproxy:release/v1.4 May 14, 2025
47 of 49 checks passed
shawnh2 pushed a commit to shawnh2/gateway that referenced this pull request Sep 15, 2025
…pace mode (envoyproxy#6067)

fix: custom controller namespace refs in gateway namespace mode (envoyproxy#6065)

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants