feat: support user-facing version#609
Conversation
7f32616 to
c72cd68
Compare
01a8f23 to
7b1e508
Compare
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 63.54% 63.69% +0.15%
==========================================
Files 47 47
Lines 5766 5749 -17
==========================================
- Hits 3664 3662 -2
+ Misses 1877 1862 -15
Partials 225 225
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4cb7b11 to
89ccea5
Compare
danehans
left a comment
There was a problem hiding this comment.
Looks like you have stale quickstart-related changes that should be removed from this PR.
|
IMHO having too many options can cause confusion. I prefer Thoughts @arkodg @youngnick @skriss @LukeShu @AliceProxy |
|
Plus one on keeping it simple. For example, you can |
|
Yes I am intending to just keep |
|
I have removed the --version for syncing the style. But need some feedback from #615 (comment). The eg version will be updated normally well and automatically in local, but wil not be in the GA, missing the Git Tree infos. That is why |
|
Xunzhuo
left a comment
There was a problem hiding this comment.
/wait
I am not sure and not recomment to put this into v0.2.0, I think a couple of things need more discussion.
@Xunzhuo converted to draft in the meantime. |
Signed-off-by: bitliu <bitliu@tencent.com>
Resolves: #498
Fixes: #615
Requires: #639
Signed-off-by: bitliu bitliu@tencent.com