Skip to content

fix: default accesslog not working #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 2 commits into from
Jul 2, 2025
Merged

fix: default accesslog not working #6441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa44eb
fix default accesslog
zirain Jul 1, 2025
b476119
release notes
zirain Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions internal/gatewayapi/listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,11 +590,6 @@ func (t *Translator) processAccessLog(envoyproxy *egv1a1.EnvoyProxy, resources *
}
irAccessLog.Text = append(irAccessLog.Text, al)
case egv1a1.ProxyAccessLogFormatTypeJSON:
if len(format.JSON) == 0 {
// TODO: use a default JSON format if not specified?
continue
}

al := &ir.JSONAccessLog{
JSON: format.JSON,
Path: sink.File.Path,
Expand Down
4 changes: 3 additions & 1 deletion internal/gatewayapi/testdata/envoyproxy-accesslog-file-json-no-format.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ infraIR:
namespace: envoy-gateway-system
xdsIR:
envoy-gateway/gateway-1:
accessLog: {}
accessLog:
json:
- path: /dev/stdout
http:
- address: 0.0.0.0
hostnames:
Expand Down
2 changes: 2 additions & 0 deletions internal/gatewayapi/testdata/envoyproxy-accesslog-without-format.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ xdsIR:
protocol: GRPC
name: envoy-gateway-system/test
type: TCP
json:
- path: /dev/stdout
openTelemetry:
- authority: otel-collector.monitoring.svc.cluster.local
destination:
Expand Down
1 change: 1 addition & 0 deletions release-notes/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ bug fixes: |
Fixed issue where EnvoyExtensionPolicy ExtProc body processing mode is set to FullDuplexStreamed, but trailers were not sent.
Fixed validation issue where EnvoyExtensionPolicy ExtProc failOpen is true, and body processing mode FullDuplexStreamed is not rejected.
Add ConfigMap indexers for EnvoyExtensionPolicies to reconcile Lua changes
Fixed issue that default accesslog format not working.


# Enhancements that improve performance.
Expand Down