internal/gatewayapi: support HTTP method matching#658
Merged
Conversation
Closes envoyproxy#655. Signed-off-by: Steve Kriss <krisss@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 62.92% 62.56% -0.37%
==========================================
Files 47 47
Lines 5756 5762 +6
==========================================
- Hits 3622 3605 -17
- Misses 1903 1925 +22
- Partials 231 232 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Oct 28, 2022
arkodg
approved these changes
Oct 28, 2022
Contributor
|
@skriss does a conformance test exist for this functionality? |
Contributor
Author
Yes but it's not in the GWAPI v0.5.1 release so we can't easily run it yet -- see #658 (comment) and #659. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #655.
Signed-off-by: Steve Kriss krisss@vmware.com
Note, the conformance test for this was added after Gateway API v0.5.1 so we can't run it until we pick up v0.6.0, but here are the results from running it manually from
main:--- PASS: TestConformance (17.18s) --- PASS: TestConformance/HTTPRouteMethodMatching (1.04s) --- PASS: TestConformance/HTTPRouteMethodMatching/2_request_to_'/'_should_receive_a_404 (4.04s) --- PASS: TestConformance/HTTPRouteMethodMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (4.04s) --- PASS: TestConformance/HTTPRouteMethodMatching/1_request_to_'/'_should_go_to_infra-backend-v2 (4.05s)I'll file another issue to remind us to enable the test down the road.