fix listener metadata for MergeGateways#6722
Closed
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6722 +/- ##
==========================================
+ Coverage 71.00% 71.03% +0.02%
==========================================
Files 224 224
Lines 39606 39618 +12
==========================================
+ Hits 28122 28141 +19
+ Misses 9824 9818 -6
+ Partials 1660 1659 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
approved these changes
Aug 7, 2025
arkodg
reviewed
Aug 7, 2025
| Kind: "GatewayClass", | ||
| Name: t.GatewayClass.Name, | ||
| Annotations: filterEGPrefix(t.GatewayClass.Annotations), | ||
| SectionName: string(listener.Name), |
Contributor
There was a problem hiding this comment.
this will cause the same issue as before, because merging listeners, will end up creating new resource metadata since you are adding a section name
Member
Author
There was a problem hiding this comment.
internal/gatewayapi/testdata/merge-valid-multiple-gateways2.in.yaml show a stable xds when they use same section.
Member
Author
|
#6639 reverted, closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6716