chore: remove useless function and unify log format#7075
Merged
rudrakhp merged 2 commits intoenvoyproxy:mainfrom Sep 27, 2025
Merged
chore: remove useless function and unify log format#7075rudrakhp merged 2 commits intoenvoyproxy:mainfrom
rudrakhp merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (26.19%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7075 +/- ##
=======================================
Coverage 70.99% 71.00%
=======================================
Files 227 227
Lines 40441 40441
=======================================
+ Hits 28713 28714 +1
+ Misses 10028 10025 -3
- Partials 1700 1702 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Sep 26, 2025
arkodg
reviewed
Sep 26, 2025
| return fmt.Errorf("failed to find envoyproxy %s/%s: %w", r.namespace, gc.Spec.ParametersRef.Name, err) | ||
| nn := types.NamespacedName{Namespace: string(*gc.Spec.ParametersRef.Namespace), Name: gc.Spec.ParametersRef.Name} | ||
| if err := r.client.Get(ctx, nn, ep); err != nil { | ||
| return fmt.Errorf("failed to find envoyproxy %s/%s for GatewayClass %s: %w", nn.Namespace, nn.Name, gc.Name, err) |
Contributor
There was a problem hiding this comment.
not related to this issue, but we are inconsistent with naming - gatewayClass vs GatewayClass in logging in the same file
Member
Author
There was a problem hiding this comment.
updated, make them more consitent.
arkodg
approved these changes
Sep 27, 2025
rudrakhp
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seperated from #7009