feat: support retries in ext proc

[shreealt]

What type of PR is this?

Support retry policy in ext proc.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes: #7127

Release Notes: Yes/No

[arkodg]

thanks @shreealt , can you add test cases in https://github.com/envoyproxy/gateway/tree/main/internal/gatewayapi/testdata and https://github.com/envoyproxy/gateway/tree/main/internal/xds/translator/testdata

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.96%. Comparing base (c5d6b03) to head (51bff22).
⚠️ Report is 26 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/xds/translator/extproc.go	50.00%	4 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7169      +/-   ##
==========================================
- Coverage   71.06%   70.96%   -0.11%     
==========================================
  Files         229      229              
  Lines       40942    41021      +79     
==========================================
+ Hits        29097    29112      +15     
- Misses      10127    10191      +64     
  Partials     1718     1718              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shreealt]

@arkodg, test cases added!

[shreealt]

Test data for retry policy

[shreealt]

Test data for retry policy

[arkodg]

hey @shreealt can you run make testdata again and commit those changes to satisfy the linter ?

[guydc]

Do grpc services support all the options in retry policy? It seems like the original PR that added support for retry_policy in grpc_service only covered backoff settings: envoyproxy/envoy#24701. Are other options like retryOn supported?

cc @nareddyt, @arkodg

[nareddyt]

Do grpc services support all the options in retry policy? It seems like the original PR that added support for retry_policy in grpc_service only covered backoff settings: envoyproxy/envoy#24701. Are other options like retryOn supported?

cc @nareddyt, @arkodg

IIUC Envoy has a separate gRPC client codepath for xDS config subscription vs async sidestream calls (e.g. from ext_auth and ext_proc). envoyproxy/envoy#24701 implements it for the xDS config subscription code path. I believe the regular async sidestream call client has supported retryOn correctly for a while.

Here, we see the gRPC client sets retry policy directly on the HTTP stream options - https://github.com/envoyproxy/envoy/blob/f18433b0e76190cece6cad73fd58d4fbd9284a0d/source/common/grpc/async_client_impl.cc#L130

So yes, it should be supported fully. But please double check me :)

[shreealt]

/retest

[shreealt]

/retest

[arkodg]

tests are still failing

[zirain]

LGTM, do we need a release notes for backport?

[guydc]

LGTM!

[arkodg]

LGTM thanks !

merging this one to avoid merge conflicts, lets add a release note for this in a follow up