chore: remove invalid validation#7208
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom Oct 16, 2025
Merged
Conversation
zirain
commented
Oct 13, 2025
| @@ -238,10 +238,7 @@ func validateProxyAccessLog(accessLog *egv1a1.ProxyAccessLog) []error { | |||
| errs = append(errs, err) | |||
| } | |||
| case egv1a1.ProxyAccessLogFormatTypeJSON: | |||
| if setting.Format.JSON == nil { | |||
Member
Author
There was a problem hiding this comment.
nil equals using default.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7208 +/- ##
==========================================
+ Coverage 71.08% 71.11% +0.02%
==========================================
Files 228 228
Lines 40691 40687 -4
==========================================
+ Hits 28926 28934 +8
+ Misses 10069 10059 -10
+ Partials 1696 1694 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
approved these changes
Oct 15, 2025
zhaohuabing
approved these changes
Oct 16, 2025
aburan28
pushed a commit
to aburan28/gateway
that referenced
this pull request
Oct 18, 2025
Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Adam Buran <aburan28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seperated from #7009