fix: use consistent cert dir between certgen and standalone run#7351
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This was referenced Oct 27, 2025
Member
Author
mathetake
commented
Oct 27, 2025
| } | ||
|
|
||
| certPath := filepath.Join(paths.DataHome, "certs") | ||
| certPath := paths.CertDir("") |
Member
Author
There was a problem hiding this comment.
this is the actual fix which makes this match with
// CertDir returns the certificate directory path (under ConfigHome).
func (p *Paths) CertDir(component string) string {
return filepath.Join(p.ConfigHome, "certs", component)
}
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (44.44%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7351 +/- ##
==========================================
- Coverage 72.05% 72.00% -0.05%
==========================================
Files 230 230
Lines 33379 33379
==========================================
- Hits 24050 24036 -14
- Misses 7583 7595 +12
- Partials 1746 1748 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Oct 28, 2025
jukie
approved these changes
Oct 28, 2025
Contributor
|
/retest |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes an inconsistency described in #7225 (comment) which makes the stanalone default mode works as expected.
What this PR does / why we need it:
This fixes the inconsistency between the dir where cergen generates certs vs the dir standalone mode expects to see TLS certs when no dir specifying env vars are not present, notably default behavor.
Which issue(s) this PR fixes:
N/A
Release Notes:No