Skip to content

Updates Kube Provider to Support Unmanaged HTTPRoutes #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danehans wants to merge 1 commit into from
+2 −2
Closed

Updates Kube Provider to Support Unmanaged HTTPRoutes #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/provider/kubernetes/httproute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func (r *httpRouteReconciler) Reconcile(ctx context.Context, request reconcile.R
// Remove the route from the watchable map since it's invalid.
r.resources.HTTPRoutes.Delete(routeKey)
r.log.Error(err, "invalid parentRefs for httproute")
return reconcile.Result{}, nil
continue
}
log.Info("validated httproute parentRefs")

Expand All @@ -223,7 +223,7 @@ func (r *httpRouteReconciler) Reconcile(ctx context.Context, request reconcile.R
// a managed Gateway.
log.Info("httproute doesn't reference any managed gateways")
r.resources.HTTPRoutes.Delete(routeKey)
return reconcile.Result{}, nil
continue
}

// only store the resource if it does not exist or it has a newer spec.
Expand Down