fix: use UnsupportedValue as the reason for unresolved filters#7642
Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom Dec 3, 2025
Merged
fix: use UnsupportedValue as the reason for unresolved filters#7642zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7642 +/- ##
==========================================
+ Coverage 72.41% 72.45% +0.03%
==========================================
Files 232 232
Lines 34278 34278
==========================================
+ Hits 24824 24835 +11
+ Misses 7679 7669 -10
+ Partials 1775 1774 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
previously approved these changes
Dec 2, 2025
Member
|
LGTM! |
Member
|
non-bloking: should we update function comment too? |
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Member
Author
InvalidKind is just an example in the GEP, and it's not the only reason. I removed it from the comments. |
Member
Got it. thanks! |
kkk777-7
approved these changes
Dec 3, 2025
jukie
approved these changes
Dec 3, 2025
rudrakhp
pushed a commit
to rudrakhp/gateway
that referenced
this pull request
Apr 27, 2026
…proxy#7642) * use UnsupportedValue as the reason for unresolved filters Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * update comments Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
added a commit
that referenced
this pull request
Apr 27, 2026
* fix: reason with multiple errors rejected validation (#8859) * fix: reason with multiple errors rejected validation Signed-off-by: zirain <zirain2009@gmail.com> * release notes Signed-off-by: zirain <zirain2009@gmail.com> * fix lint Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> * fix: use UnsupportedValue as the reason for unresolved filters (#7642) * use UnsupportedValue as the reason for unresolved filters Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * update comments Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Co-authored-by: zirain <zirain2009@gmail.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #7603