Skip to content

fix: use UnsupportedValue as the reason for unresolved filters#7642

Merged
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-7603
Dec 3, 2025
Merged

fix: use UnsupportedValue as the reason for unresolved filters#7642
zhaohuabing merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-7603

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

fix: #7603

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.45%. Comparing base (986c609) to head (80568ba).
⚠️ Report is 547 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7642      +/-   ##
==========================================
+ Coverage   72.41%   72.45%   +0.03%     
==========================================
  Files         232      232              
  Lines       34278    34278              
==========================================
+ Hits        24824    24835      +11     
+ Misses       7679     7669      -10     
+ Partials     1775     1774       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kkk777-7
kkk777-7 previously approved these changes Dec 2, 2025
@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Dec 2, 2025

LGTM!

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Dec 2, 2025

non-bloking:

should we update function comment too?
InvalidKind -> UnsupportedValue

// Unresolvable or unsupported filters should be treated like other reference failures:
// (`Accepted` will be set to true, `ResolvedRefs` to false with a `InvalidKind` Reason,
// and traffic that would have matched the filter should receive a 500 error.)
// ref: https://gateway-api.sigs.k8s.io/geps/gep-1364/#new-and-updated-conditions
func (t *Translator) processUnresolvedHTTPFilter(errMsg string, filterContext *HTTPFiltersContext) status.Error {

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member Author

zhaohuabing commented Dec 3, 2025

InvalidKind

InvalidKind is just an example in the GEP, and it's not the only reason. I removed it from the comments.

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Dec 3, 2025

InvalidKind is just an example in the GEP, and it's not the only reason. I removed it from the comments.

Got it. thanks!

@zhaohuabing zhaohuabing merged commit 1db9764 into envoyproxy:main Dec 3, 2025
52 of 55 checks passed
@zhaohuabing zhaohuabing deleted the fix-7603 branch December 3, 2025 09:55
rudrakhp pushed a commit to rudrakhp/gateway that referenced this pull request Apr 27, 2026
…proxy#7642)

* use UnsupportedValue as the reason for unresolved filters

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update comments

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp added a commit that referenced this pull request Apr 27, 2026
* fix: reason with multiple errors rejected validation (#8859)

* fix: reason with multiple errors rejected validation

Signed-off-by: zirain <zirain2009@gmail.com>

* release notes

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>

* fix: use UnsupportedValue as the reason for unresolved filters (#7642)

* use UnsupportedValue as the reason for unresolved filters

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update comments

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update reason from BackendNotFound to something better for this case in the future

5 participants