Skip to content

[provider] unit tests for predicate functions#798

Merged
danehans merged 5 commits into
envoyproxy:mainfrom
chauhanshubham:chauhan-things
Dec 15, 2022
Merged

[provider] unit tests for predicate functions#798
danehans merged 5 commits into
envoyproxy:mainfrom
chauhanshubham:chauhan-things

Conversation

@chauhanshubham
Copy link
Copy Markdown
Member

@chauhanshubham chauhanshubham commented Dec 12, 2022

Resolves #772
Signed-off-by: Shubham Chauhan shubham@tetrate.io

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
@chauhanshubham chauhanshubham marked this pull request as ready for review December 12, 2022 18:34
@chauhanshubham chauhanshubham requested a review from a team as a code owner December 12, 2022 18:34
Comment thread internal/provider/kubernetes/test/utils.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.22%. Comparing base (b43a492) to head (539eaaa).
⚠️ Report is 4021 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   62.00%   63.22%   +1.22%     
==========================================
  Files          46       46              
  Lines        5995     6157     +162     
==========================================
+ Hits         3717     3893     +176     
+ Misses       2045     2023      -22     
- Partials      233      241       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/provider/kubernetes/predicates.go
Comment thread internal/provider/kubernetes/predicates.go Outdated
Comment thread internal/provider/kubernetes/predicates_test.go
Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
@danehans danehans merged commit d56ea6a into envoyproxy:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[provider] unit tests for predicate functions

3 participants