Skip to content

fix status subscriber shutdown log#800

Merged
danehans merged 1 commit into
envoyproxy:mainfrom
chauhanshubham:chauhan-799
Dec 13, 2022
Merged

fix status subscriber shutdown log#800
danehans merged 1 commit into
envoyproxy:mainfrom
chauhanshubham:chauhan-799

Conversation

@chauhanshubham
Copy link
Copy Markdown
Member

@chauhanshubham chauhanshubham commented Dec 12, 2022

Resolves #799
Signed-off-by: Shubham Chauhan shubham@tetrate.io

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
@chauhanshubham chauhanshubham requested a review from a team as a code owner December 12, 2022 20:02
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #800 (49d9872) into main (b758d65) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   61.85%   61.94%   +0.09%     
==========================================
  Files          46       46              
  Lines        5995     5997       +2     
==========================================
+ Hits         3708     3715       +7     
+ Misses       2051     2048       -3     
+ Partials      236      234       -2     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 50.67% <0.00%> (+0.57%) ⬆️
internal/provider/kubernetes/helpers.go 75.80% <0.00%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans
Copy link
Copy Markdown
Contributor

/lgtm

@danehans danehans merged commit ed5680a into envoyproxy:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper Log Messaging at Startup

5 participants