Skip to content

Refactors Reconciler() Method for Kubernetes Provider#803

Closed
danehans wants to merge 1 commit into
envoyproxy:mainfrom
danehans:issue_788
Closed

Refactors Reconciler() Method for Kubernetes Provider#803
danehans wants to merge 1 commit into
envoyproxy:mainfrom
danehans:issue_788

Conversation

@danehans
Copy link
Copy Markdown
Contributor

Refactors Kubernetes controller:

  • Improves readability.
  • Improves log messages.
  • Updates the reconciler to continue processing a request even if dependent resources cannot be found.

Fixes #788

Signed-off-by: danehans daneyonhansen@gmail.com

Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans danehans requested a review from a team as a code owner December 12, 2022 23:02
@danehans danehans added this to the 0.3.0-rc.1 milestone Dec 12, 2022
@danehans
Copy link
Copy Markdown
Contributor Author

cc: @chauhanshubham

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 12, 2022

Codecov Report

❌ Patch coverage is 20.00000% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.77%. Comparing base (b43a492) to head (84e720d).
⚠️ Report is 4046 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 20.23% 65 Missing and 2 partials ⚠️
internal/provider/kubernetes/routes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   62.00%   61.77%   -0.23%     
==========================================
  Files          46       46              
  Lines        5995     6023      +28     
==========================================
+ Hits         3717     3721       +4     
- Misses       2045     2068      +23     
- Partials      233      234       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danehans
Copy link
Copy Markdown
Contributor Author

This PR is required to enable the HTTPRouteReferenceGrant conformance test.

@danehans danehans marked this pull request as draft December 14, 2022 18:42
@danehans
Copy link
Copy Markdown
Contributor Author

Superseded by #793

@danehans danehans closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backendref service not found causes xds no message received

2 participants