Skip to content

feat: invalid listener should not block IR#8194

Merged
cnvergence merged 1 commit into
envoyproxy:mainfrom
zirain:TLSRouteInvalidNoMatchingListener
Mar 2, 2026
Merged

feat: invalid listener should not block IR#8194
cnvergence merged 1 commit into
envoyproxy:mainfrom
zirain:TLSRouteInvalidNoMatchingListener

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Feb 6, 2026

xref: #3673
Find this when debugging TLSRouteInvalidNoMatchingListener, also this should be part of kubernetes-sigs/gateway-api#4425

@zirain zirain requested a review from a team as a code owner February 6, 2026 07:29
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 6, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit add89bf
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69a2eddf2f26da0008428b61
😎 Deploy Preview https://deploy-preview-8194--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch from 79d5334 to f9d8860 Compare February 6, 2026 10:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.83%. Comparing base (7c38b58) to head (add89bf).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8194      +/-   ##
==========================================
- Coverage   73.84%   73.83%   -0.01%     
==========================================
  Files         242      242              
  Lines       37061    37058       -3     
==========================================
- Hits        27366    27363       -3     
  Misses       7764     7764              
  Partials     1931     1931              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cnvergence
cnvergence previously approved these changes Feb 6, 2026
Copy link
Copy Markdown
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e failing :(

@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch from f9d8860 to 499c523 Compare February 6, 2026 11:47
@cnvergence cnvergence self-requested a review February 6, 2026 11:48
@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch from 499c523 to aa7f516 Compare February 6, 2026 11:49
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Feb 6, 2026

/retest

@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Feb 8, 2026
Comment thread internal/gatewayapi/testdata/xlistenerset-invalid.out.yaml Outdated
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Feb 11, 2026

xref: #8244

@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch from aa7f516 to fe98987 Compare February 11, 2026 01:17
@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch 3 times, most recently from 98284ee to ccc53b1 Compare February 25, 2026 09:15
@zirain zirain requested a review from arkodg February 26, 2026 03:01
@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch 3 times, most recently from a25662b to f396151 Compare February 28, 2026 05:15
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the TLSRouteInvalidNoMatchingListener branch from f396151 to add89bf Compare February 28, 2026 13:30
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@cnvergence cnvergence merged commit 815b71b into envoyproxy:main Mar 2, 2026
95 of 105 checks passed
This was referenced Mar 2, 2026
@zirain zirain deleted the TLSRouteInvalidNoMatchingListener branch March 2, 2026 08:35
antonio-mazzini pushed a commit to antonio-mazzini/gateway that referenced this pull request Mar 5, 2026
invalid listener should not block IR

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants