Fix package import for HTTPRouteFilterExtensionRef#821
Merged
Conversation
Caused by merging envoyproxy#791 without rebasing envoyproxy#816 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Contributor
Author
|
looks like the tests also need to be updated to use the indexes in the tests |
was failing with below error
```
--- FAIL: TestProcessHTTPRoutes/httproute_with_one_authenticationfilter (0.00s)
routes_test.go:221:
Error Trace: /Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/routes_test.go:221
Error: Received unexpected error:
List on GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute specifies selector on field gatewayHTTPRouteIndex, but no index with name gatewayHTTPRouteIndex has been registered for GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute
Test: TestProcessHTTPRoutes/httproute_with_one_authenticationfilter
```
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 64.14% 64.03% -0.12%
==========================================
Files 46 46
Lines 6103 6203 +100
==========================================
+ Hits 3915 3972 +57
- Misses 1952 1989 +37
- Partials 236 242 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by merging #791 without rebasing #816
Signed-off-by: Arko Dasgupta arko@tetrate.io