Skip to content

fix load balancing e2e test#8352

Closed
zirain wants to merge 3 commits into
envoyproxy:mainfrom
zirain:e2e/lb
Closed

fix load balancing e2e test#8352
zirain wants to merge 3 commits into
envoyproxy:mainfrom
zirain:e2e/lb

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Feb 26, 2026

#8349 didn't fix it at all
This PR refactor the e2e tests:

  • Unify the backend for load balancing cases
  • Add readinessProbe to app-backend-lb deployment to make sure all the pods ready before run traffic tests.

@zirain zirain requested a review from a team as a code owner February 26, 2026 09:07
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 26, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit c669582
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69a106ae43e4160008e3b9e2

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.83%. Comparing base (ed18c9c) to head (c669582).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8352   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files         242      242           
  Lines       37064    37064           
=======================================
  Hits        27365    27365           
  Misses       7767     7767           
  Partials     1932     1932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cnvergence
cnvergence previously approved these changes Feb 26, 2026
@zhaohuabing
Copy link
Copy Markdown
Member

Looks like the load balancing tests are still failing.

    --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing (67.62s)
        --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo1 (30.07s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo2 (0.06s)
        --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo3 (30.07s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo4 (0.06s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo5 (0.07s)

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Feb 26, 2026

Looks like the load balancing tests are still failing.

    --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing (67.62s)
        --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo1 (30.07s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo2 (0.06s)
        --- FAIL: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo3 (30.07s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo4 (0.06s)
        --- PASS: TestE2E/QueryParamsBasedConsistentHashLoadBalancing/combo5 (0.07s)

yeah, no idea why this happen.

@zhaohuabing
Copy link
Copy Markdown
Member

Should we disable these tests for now? They're blocking CI.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Feb 27, 2026

let's disabled it.

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member

zhaohuabing commented Feb 27, 2026

Hi @Zirian — thanks for taking care of this.

Just FYI, in the community meeting, the conclusion was to give this a bit more time to resolve properly rather than disabling the tests, since this is an important feature that users rely on.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Feb 27, 2026

I have no idea why this happen, let me close this for someone know more.

@zirain zirain closed this Feb 27, 2026
@zirain zirain deleted the e2e/lb branch February 27, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants