fix: Add overlap status for duplicate HTTPRoutes#8373
Open
jukie wants to merge 16 commits into
Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8373 +/- ##
==========================================
+ Coverage 74.37% 74.43% +0.06%
==========================================
Files 246 246
Lines 39287 39443 +156
==========================================
+ Hits 29218 29359 +141
- Misses 8040 8050 +10
- Partials 2029 2034 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Member
|
Ignore above, it's fixed by #8186 |
arkodg
reviewed
Mar 1, 2026
arkodg
reviewed
Mar 1, 2026
arkodg
reviewed
Mar 1, 2026
zhaohuabing
reviewed
Mar 2, 2026
Signed-off-by: jukie <isaac.wilson514@gmail.com>
Signed-off-by: jukie <isaac.wilson514@gmail.com>
zhaohuabing
reviewed
Mar 10, 2026
zhaohuabing
reviewed
Mar 10, 2026
zhaohuabing
reviewed
Mar 10, 2026
Contributor
Author
|
/retest |
…rlaps Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Contributor
Author
|
/retest |
zhaohuabing
reviewed
Apr 10, 2026
zhaohuabing
reviewed
Apr 10, 2026
zhaohuabing
reviewed
Apr 10, 2026
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe3d5bf7c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The first route that gets applied will take precedence but subsequent routes don't show any indication that they're being ignored. This adds a an
Overlapstatus to ResolvedRefs to communicate this behavior to users.Fixes #8101
Release Notes: Yes