Skip to content

Addlicense#84

Closed
arkodg wants to merge 1 commit intoenvoyproxy:mainfrom
arkodg:make-license
Closed

Addlicense#84
arkodg wants to merge 1 commit intoenvoyproxy:mainfrom
arkodg:make-license

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented May 31, 2022

  • Add tooling inside the Makefile to install tooling
    needed for various make targets
  • Install & run addlicense which adds missing license header
    to files

Relates to #60

Signed-off-by: Arko Dasgupta arko@tetrate.io

* Add tooling inside the Makefile to install tooling
needed to various make targets
* Install & run `addlicense` which adds missing license header
to files

Relates to envoyproxy#60

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Jun 2, 2022

@arkodg controller-gen can manage boilerplate code such as license headers. For example:

go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."

Where hack/boilerplate.go.txt containers the license header:

# Copyright 2022 Envoyproxy Authors
...

This seems like a more streamlined approach for managing license headers.

Copy link
Copy Markdown
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #84 (comment) for my review feedback.

@LukeShu
Copy link
Copy Markdown
Contributor

LukeShu commented Jun 2, 2022

@danehans:

controller-gen can manage boilerplate code such as license headers. For example: …

That'll control the license header that controller-gen includes in files that it generates; but controller-gen won't touch human-generated files that a human forgot to add a license header too, which is what the addlicense tool seems to do.

@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Jun 3, 2022

closing based on comments from #92 mentioning that having a license in every file is not needed

@arkodg arkodg closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants