Skip to content

feat: add envoyproxy status#8475

Open
zirain wants to merge 10 commits intoenvoyproxy:mainfrom
zirain:impl-envoyproxy-status
Open

feat: add envoyproxy status#8475
zirain wants to merge 10 commits intoenvoyproxy:mainfrom
zirain:impl-envoyproxy-status

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Mar 10, 2026

This's the first part of implement envoyproxy status, set EnvoyProxy status when it's invalid.
We may want to remove the one on Gateway/GatewayClass in the next step.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 10, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 27ab1fb
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e054b33b7ffd00086199a6
😎 Deploy Preview https://deploy-preview-8475--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 54.88722% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.23%. Comparing base (1baf309) to head (27ab1fb).

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 26.82% 26 Missing and 4 partials ⚠️
internal/provider/kubernetes/status.go 15.62% 26 Missing and 1 partial ⚠️
internal/provider/kubernetes/controller.go 57.14% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (54.88%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8475      +/-   ##
==========================================
- Coverage   74.30%   74.23%   -0.08%     
==========================================
  Files         245      246       +1     
  Lines       38801    38926     +125     
==========================================
+ Hits        28831    28896      +65     
- Misses       7966     8022      +56     
- Partials     2004     2008       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain marked this pull request as ready for review March 12, 2026 01:52
@zirain zirain requested a review from a team as a code owner March 12, 2026 01:52
@zirain zirain force-pushed the impl-envoyproxy-status branch from b810b41 to 81f65cc Compare March 12, 2026 01:52
@zirain zirain changed the title feat: impl envoyproxy status feat: add envoyproxy status Mar 12, 2026
Comment thread internal/gatewayapi/status/envoyproxy.go Outdated
@zirain zirain force-pushed the impl-envoyproxy-status branch 2 times, most recently from 5e08ea1 to 8ddd7d2 Compare March 13, 2026 06:22
@zirain zirain added this to the v1.8.0-rc.1 Release milestone Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels Apr 12, 2026
Comment thread internal/cmd/egctl/testdata/translate/out/valid-envoyproxy.all.yaml Outdated
@zhaohuabing
Copy link
Copy Markdown
Member

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ddd7d2f5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/gatewayapi/status/envoyproxy.go Outdated
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no conformance tests for EnvoyProxy status, can we add an e2e test to ensure the runtime behavior is correct?

@zirain zirain force-pushed the impl-envoyproxy-status branch from 8ddd7d2 to e182386 Compare April 15, 2026 05:27
zirain added 7 commits April 15, 2026 14:15
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the impl-envoyproxy-status branch from 5c363c6 to b4fd2d6 Compare April 15, 2026 06:19
@zirain zirain requested a review from zhaohuabing April 15, 2026 10:11
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 15, 2026

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a17a9b6e49

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/gatewayapi/runner/runner.go Outdated
Comment thread internal/provider/kubernetes/status.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants