feat(loadbalancer): support slow start aggression and minWeightPercent#8717
Open
aburan28 wants to merge 4 commits intoenvoyproxy:mainfrom
Open
feat(loadbalancer): support slow start aggression and minWeightPercent#8717aburan28 wants to merge 4 commits intoenvoyproxy:mainfrom
aburan28 wants to merge 4 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aburan28
force-pushed
the
adam--slow-start-aggression
branch
from
eb20c37 to
3144c52
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8717 +/- ##
==========================================
- Coverage 74.35% 74.34% -0.01%
==========================================
Files 245 245
Lines 38847 38861 +14
==========================================
+ Hits 28883 28893 +10
- Misses 7963 7966 +3
- Partials 2001 2002 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
reviewed
Apr 11, 2026
aburan28
force-pushed
the
adam--slow-start-aggression
branch
from
4bcb284 to
198ec9a
Compare
Expose the `aggression` and `minWeightPercent` parameters of Envoy's SlowStartConfig via BackendTrafficPolicy. Previously only the slow start `window` was configurable, which limited users to a linear ramp-up. `aggression` enables polynomial/exponential ramp-up curves, and `minWeightPercent` guards against starvation when the scaled weight would otherwise approach zero. Addresses the existing TODO in the SlowStart API type. Signed-off-by: Adam Buran <aburan28@gmail.com>
…ggression Change SlowStart.Aggression from a decimal string (e.g. "1.5") to a percentage-based uint32 where 100 represents 1.0x, matching the convention used by BackendUtilization.ErrorUtilizationPenaltyPercent in the same struct family. This removes the regex pattern and CEL XValidation rule from the API type, drops the strconv.ParseFloat call in the gatewayapi translator (and its runtime error path), and relies on a simple Minimum=1 validation instead. Per review feedback on #3144c52fc. Signed-off-by: Adam Buran <aburan28@gmail.com>
aburan28
force-pushed
the
adam--slow-start-aggression
branch
2 times, most recently
from
c92b3d1 to
82d8a3b
Compare
… lint Signed-off-by: Adam Buran <aburan28@gmail.com>
aburan28
force-pushed
the
adam--slow-start-aggression
branch
from
82d8a3b to
4d362b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for two new load balancer configuration options:
Files Modified
loadbalancer_types.gowith new fields and generated deepcopy methodsclustersettings.gocluster.goto support new optionsbackendtrafficpolicy_test.goand test data fixturesTesting