Skip to content

Bump to gateway api v0.6.0#874

Merged
arkodg merged 3 commits into
envoyproxy:mainfrom
arkodg:gapi-bump-v0.6.0
Jan 10, 2023
Merged

Bump to gateway api v0.6.0#874
arkodg merged 3 commits into
envoyproxy:mainfrom
arkodg:gapi-bump-v0.6.0

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Jan 9, 2023

  • update go module
  • copy over newer experimental CRDs into testdata
  • incorporate ObservedGeneration into status condition comparisons
  • ensure that the two gateway status update code paths (one when a service or deployment linked to a gateway changes and the second where the gateway-api translator has recomputed the status) use the same status updater function, ensuring that the ObservedGeneration is always up to date in all status fields

Fixes: #716 Fixes: #839

Signed-off-by: Arko Dasgupta arko@tetrate.io

* update go module
* copy over newer experimental CRDs into testdata
* incorporate ObservedGeneration into status condition comparisons

Fixes: envoyproxy#716
Fixes: envoyproxy#839

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner January 9, 2023 18:39
@arkodg arkodg marked this pull request as draft January 9, 2023 18:39
Arko Dasgupta added 2 commits January 9, 2023 11:36
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2023

Codecov Report

❌ Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.13%. Comparing base (b05aa93) to head (08eb586).
⚠️ Report is 4007 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 40.00% 7 Missing and 2 partials ⚠️
internal/gatewayapi/contexts.go 50.00% 0 Missing and 2 partials ⚠️
internal/status/gateway.go 0.00% 2 Missing ⚠️
internal/status/status.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   63.91%   64.13%   +0.22%     
==========================================
  Files          51       52       +1     
  Lines        6869     7129     +260     
==========================================
+ Hits         4390     4572     +182     
- Misses       2203     2275      +72     
- Partials      276      282       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg arkodg marked this pull request as ready for review January 9, 2023 21:31
@arkodg arkodg mentioned this pull request Jan 9, 2023
@arkodg arkodg requested review from Xunzhuo and skriss January 9, 2023 21:56
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit 35c4f63 into envoyproxy:main Jan 10, 2023
@arkodg arkodg deleted the gapi-bump-v0.6.0 branch January 10, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump Kube Provider Test Data Manifests to v0.6.0 Update to the v0.6.0 Gateway API release

3 participants