Skip to content

fix: use per-route ratelimit filter#8741

Merged
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:ratelimit-filter
Apr 21, 2026
Merged

fix: use per-route ratelimit filter#8741
zirain merged 5 commits intoenvoyproxy:mainfrom
zirain:ratelimit-filter

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 13, 2026

fixes: #8707

use use per-route ratelimit configuration for non-shared rules.

@zirain zirain requested a review from a team as a code owner April 13, 2026 23:39
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 13, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 3ad6fdb
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e6abad8afa140008b40458

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.43%. Comparing base (c97626e) to head (3ad6fdb).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/httpfilters.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8741      +/-   ##
==========================================
+ Coverage   74.39%   74.43%   +0.03%     
==========================================
  Files         245      245              
  Lines       38972    38977       +5     
==========================================
+ Hits        28995    29013      +18     
+ Misses       7971     7963       -8     
+ Partials     2006     2001       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain added this to the v1.8.0-rc.1 Release milestone Apr 16, 2026
zirain added 3 commits April 20, 2026 12:58
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the ratelimit-filter branch from cbdc9fe to 2fa2fa4 Compare April 20, 2026 04:58
Signed-off-by: zirain <zirain2009@gmail.com>
Comment thread internal/xds/translator/ratelimit.go
Comment thread internal/xds/translator/ratelimit.go
Signed-off-by: zirain <zirain2009@gmail.com>
@kkk777-7
Copy link
Copy Markdown
Member

LGTM, thanks!

@kkk777-7
Copy link
Copy Markdown
Member

/retest

@zirain zirain merged commit 85e62dd into envoyproxy:main Apr 21, 2026
80 of 85 checks passed
@zirain zirain deleted the ratelimit-filter branch April 21, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BackendTrafficPolicy rate limiting attached to Gateway only applies to one listener

3 participants