fix: ContextExtensions merge behavior#8747
Merged
Merged
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8747 +/- ##
==========================================
- Coverage 74.30% 74.28% -0.02%
==========================================
Files 245 245
Lines 38801 38801
==========================================
- Hits 28830 28825 -5
- Misses 7967 7972 +5
Partials 2004 2004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
approved these changes
Apr 14, 2026
Member
|
LGTM, thanks! I've confirmed in #8538 that correct output in strategicmerge testfile. |
Member
Author
|
/retest |
zirain
approved these changes
Apr 15, 2026
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
fix ContextExtensions merge behavior Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #8538 (comment)