feat(translator): HealthCheck Event Logs#8753
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43aae07eb4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8753 +/- ##
==========================================
- Coverage 74.43% 73.64% -0.80%
==========================================
Files 245 245
Lines 38973 48858 +9885
==========================================
+ Hits 29010 35980 +6970
- Misses 7960 10872 +2912
- Partials 2003 2006 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0277eb3961
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| count, err := QueryLogCountFromLoki(t, suite.Client, lokiLabels, "health_checker_type") | ||
| require.NoError(t, err, "loki query failed") | ||
| require.Equal(t, 0, count, "expected no HC events before HC-enabled route is active") |
There was a problem hiding this comment.
QueryLogCountFromLoki searches the last 10 minutes across all Envoy containers matching job/namespace/container, so this strict count == 0 assertion can fail whenever earlier tests or retries already emitted health_checker_type logs in the same namespace. In shared or retried CI runs, that makes this test flaky even if the "no HC route" behavior is correct; capture a pre-test baseline (or narrow labels to this gateway pod) and assert no increase instead.
Useful? React with 👍 / 👎.
Signed-off-by: Guy Daich <guy.daich@sap.com>
1 participant
What this PR does / why we need it:
Adds support for enabling active healtcheck logs via
EnvoyProxyTelemetry.Release Notes: Yes