Skip to content

chore: fix race and panic#8795

Open
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
zirain:fix-race-panic
Open

chore: fix race and panic#8795
zirain wants to merge 2 commits intoenvoyproxy:mainfrom
zirain:fix-race-panic

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 20, 2026

The goroutine continues to process messages and log after the test completes. The logger writes to the test's output, causing a data race.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner April 20, 2026 04:53
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 964e2e6
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e6f23e3d0e390007f3b4e7

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.35%. Comparing base (c97626e) to head (964e2e6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/runner/runner.go 12.50% 21 Missing ⚠️

❌ Your patch check has failed because the patch coverage (12.50%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8795      +/-   ##
==========================================
- Coverage   74.39%   74.35%   -0.05%     
==========================================
  Files         245      245              
  Lines       38972    38993      +21     
==========================================
- Hits        28995    28992       -3     
- Misses       7971     7995      +24     
  Partials     2006     2006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rudrakhp
rudrakhp previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Member

@rudrakhp rudrakhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to #8689 ?

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 20, 2026

Is it related to #8689 ?

Most likely

@rudrakhp rudrakhp requested review from a team April 20, 2026 09:51
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 21, 2026

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f4e854602

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/envoygateway/config/loader/configloader_test.go Outdated
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Apr 21, 2026

@codex

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants