Skip to content

Enable HTTPRouteMethodMatching conformance test#880

Merged
arkodg merged 1 commit into
envoyproxy:mainfrom
datawire:hqudsi/http-route-method-matching-conformance
Jan 10, 2023
Merged

Enable HTTPRouteMethodMatching conformance test#880
arkodg merged 1 commit into
envoyproxy:mainfrom
datawire:hqudsi/http-route-method-matching-conformance

Conversation

@haq204
Copy link
Copy Markdown
Contributor

@haq204 haq204 commented Jan 10, 2023 •
edited
Loading

Fixes #659

Enable the HTTPRoute method matching test after updating gateway API to v0.6.0

Letting the tests run first to see if other things needed to be updated/fixed

@haq204 haq204 requested a review from a team as a code owner January 10, 2023 15:23
enable HTTPRouteMethodMatching conformance test
0ef2c01 
Signed-off-by: Hamzah Qudsi <hqudsi@datawire.io>
@haq204 haq204 force-pushed the hqudsi/http-route-method-matching-conformance branch from f1305b3 to 0ef2c01 Compare January 10, 2023 15:25
@haq204
Copy link
Copy Markdown
Contributor Author

haq204 commented Jan 10, 2023

Forgot to add my DCO signoff

arkodg
arkodg approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 10, 2023

adding the test snippet from the CI logs here

2023-01-10T16:49:34.5439492Z     --- PASS: TestGatewayAPIConformance/HTTPRouteMethodMatching (1.03s)
2023-01-10T16:49:34.5440307Z         --- PASS: TestGatewayAPIConformance/HTTPRouteMethodMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (0.00s)
2023-01-10T16:49:34.5441126Z         --- PASS: TestGatewayAPIConformance/HTTPRouteMethodMatching/2_request_to_'/'_should_receive_a_404 (0.00s)
2023-01-10T16:49:34.5441949Z         --- PASS: TestGatewayAPIConformance/HTTPRouteMethodMatching/1_request_to_'/'_should_go_to_infra-backend-v2 (0.00s)

@arkodg arkodg merged commit 8dd60b1 into envoyproxy:main Jan 10, 2023
@haq204 haq204 deleted the hqudsi/http-route-method-matching-conformance branch January 10, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable HTTPRoute method matching conformance test

3 participants

@haq204 @arkodg @Xunzhuo