Skip to content

Add support for extraVolumes and extraVolumeMounts to EG deployment #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkhpalm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for extraVolumes and extraVolumeMounts to EG deployment #8801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/gateway-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ helm uninstall eg -n envoy-gateway-system
| deployment.pod.nodeSelector | object | `{}` | |
| deployment.pod.tolerations | list | `[]` | |
| deployment.pod.topologySpreadConstraints | list | `[]` | |
| deployment.pod.extraVolumeMounts | list | `[]` | |
| deployment.pod.extraVolumes | list | `[]` | |
| deployment.ports[0].name | string | `"grpc"` | |
| deployment.ports[0].port | int | `18000` | |
| deployment.ports[0].targetPort | int | `18000` | |
Expand Down
6 changes: 6 additions & 0 deletions charts/gateway-helm/templates/envoy-gateway-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ spec:
- mountPath: /certs
name: certs
readOnly: true
{{- with .Values.deployment.pod.extraVolumeMounts }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- include "eg.image.pullSecrets" . | nindent 6 }}
{{- with .Values.deployment.priorityClassName }}
priorityClassName: {{ . | quote }}
Expand All @@ -108,3 +111,6 @@ spec:
- name: certs
secret:
secretName: envoy-gateway
{{- with .Values.deployment.pod.extraVolumes }}
{{- toYaml . | nindent 6 }}
{{- end }}
10 changes: 10 additions & 0 deletions charts/gateway-helm/values.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ deployment:
topologySpreadConstraints: []
tolerations: []
nodeSelector: {}
# Additional volumeMounts on the deployment definition.
extraVolumeMounts: []
# - name: foo
# mountPath: "/etc/foo"
# readOnly: true
# Additional volumes on the deployment definition.
extraVolumes: []
# - name: foo
# configMap:
# name: myconfigmap

service:
# If set to PreferClose, the Envoy fleet will prioritize connecting to the Envoy Gateway pods that are topologically closest to them.
Expand Down
16 changes: 16 additions & 0 deletions test/helm/gateway-helm/deployment-volume-mounts.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
global:
images:
envoyGateway:
image: "docker.io/envoyproxy/gateway-dev:latest"
pullPolicy: Always

deployment:
pod:
extraVolumeMounts:
- name: foo
mountPath: "/etc/foo"
readOnly: true
extraVolumes:
- name: foo
configMap:
name: myconfigmap
Loading
Loading