Draft
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8807 +/- ##
==========================================
- Coverage 74.41% 73.64% -0.77%
==========================================
Files 245 245
Lines 38977 48832 +9855
==========================================
+ Hits 29006 35964 +6958
- Misses 7967 10864 +2897
Partials 2004 2004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a synthetic operator
%EG_EXT_FILTER_STATE(name:attribute)%that EG resolves at xDS translation time to the real%FILTER_STATE(...)%key. Users assign an optional name to each extProc entry in theirEnvoyExtensionPolicyand reference it by that name in anyEnvoyProxyaccess log format string (text or JSON). Envoy only ever sees standard operators in xDS.Changes:
%EG_EXT_FILTER_STATE(name:attr)%with %FILTER_STATE(envoy.filters.http.ext_proc/:attr)% using first-match on CustomName. Unresolved operators are replaced with "-" to prevent xDS NACK.Which issue(s) this PR fixes:
Fixes #7868
Release Notes: Yes