Skip to content

feat(translator): ext proc logs#8807

Draft
guydc wants to merge 1 commit intoenvoyproxy:mainfrom
guydc:feat-ext-proc-log
Draft

feat(translator): ext proc logs#8807
guydc wants to merge 1 commit intoenvoyproxy:mainfrom
guydc:feat-ext-proc-log

Conversation

@guydc
Copy link
Copy Markdown
Contributor

@guydc guydc commented Apr 22, 2026

What this PR does / why we need it:

This PR adds a synthetic operator %EG_EXT_FILTER_STATE(name:attribute)% that EG resolves at xDS translation time to the real %FILTER_STATE(...)% key. Users assign an optional name to each extProc entry in their EnvoyExtensionPolicy and reference it by that name in any EnvoyProxy access log format string (text or JSON). Envoy only ever sees standard operators in xDS.

Changes:

  • API: Add optional Name *string field to ExtProc: the user-assigned alias for access log resolution.
  • Translation: replaces %EG_EXT_FILTER_STATE(name:attr)% with %FILTER_STATE(envoy.filters.http.ext_proc/:attr)% using first-match on CustomName. Unresolved operators are replaced with "-" to prevent xDS NACK.

Which issue(s) this PR fixes:
Fixes #7868

Release Notes: Yes

Signed-off-by: Guy Daich <guy.daich@sap.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 22, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 619a81e
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e81fe1c615fb0008b196ae
😎 Deploy Preview https://deploy-preview-8807--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.64%. Comparing base (85e62dd) to head (619a81e).

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8807      +/-   ##
==========================================
- Coverage   74.41%   73.64%   -0.77%     
==========================================
  Files         245      245              
  Lines       38977    48832    +9855     
==========================================
+ Hits        29006    35964    +6958     
- Misses       7967    10864    +2897     
  Partials     2004     2004              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ext Proc Access Logs

1 participant