Enable envoy grpc-web filter for HTTP2 listener#886
Conversation
|
Looks like some conflicts need to be resolved. |
|
yeah @Xunzhuo also hoping to discuss this in the next community meeting |
|
Is it possible to add documentation such as a quickstart or tcp-routing item? |
|
@HoangTheQuyen will make sure to add docs as part of #642, since some work items are still WIP |
There was a problem hiding this comment.
from the godoc on IsHTTP2:
// IsHTTP2 is set if the upstream client as well as the downstream server are configured to serve HTTP2 traffic.
this is a little misleading i think? since the codec type is always set to "auto" and will infer the downstream protocol which could be HTTP/1 and upgraded when talking with the backend to gRPC now that this filter is applied
There was a problem hiding this comment.
How should I configure it so that it can touch it ? @sunjayBhatia
There was a problem hiding this comment.
good point @sunjayBhatia, we could limit IsHTTP2 to downstreams speaking HTTP/2, thereby limiting grpc-web for HTTP/2 only clients
There was a problem hiding this comment.
updated the PR with the codec type change from auto to http2
There was a problem hiding this comment.
seems useful for clients to be able to use gRPC-Web over HTTP/1 -> Envoy -> gRPC backend over HTTP/2 as well! but seems like that could be a separate feature if desired
Fixes: envoyproxy#879 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 63.49% 63.52% +0.02%
==========================================
Files 53 53
Lines 7347 7361 +14
==========================================
+ Hits 4665 4676 +11
- Misses 2393 2395 +2
- Partials 289 290 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 participants
Fixes: #879
Signed-off-by: Arko Dasgupta arko@tetrate.io