Skip to content

Update GRPCRoute Context#891

Closed
HoangTheQuyen wants to merge 7 commits intoenvoyproxy:mainfrom
HoangTheQuyen:main
Closed

Update GRPCRoute Context#891
HoangTheQuyen wants to merge 7 commits intoenvoyproxy:mainfrom
HoangTheQuyen:main

Conversation

@HoangTheQuyen
Copy link
Copy Markdown

Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
@HoangTheQuyen HoangTheQuyen requested a review from a team as a code owner January 12, 2023 03:11
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #891 (6588bf6) into main (8e4e0ce) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   63.52%   63.17%   -0.36%     
==========================================
  Files          53       53              
  Lines        7361     7410      +49     
==========================================
+ Hits         4676     4681       +5     
- Misses       2395     2440      +45     
+ Partials      290      289       -1     
Impacted Files Coverage Δ
internal/gatewayapi/contexts.go 68.28% <0.00%> (-9.20%) ⬇️
internal/provider/kubernetes/controller.go 47.25% <0.00%> (+0.12%) ⬆️
internal/provider/kubernetes/helpers.go 80.32% <0.00%> (+3.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 12, 2023

plan on addressing this in #805, waiting on other features/commits to go in to reduce merge conflicts, thanks for being patient

Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants