Skip to content

lint: improve golanglint#911

Merged
Xunzhuo merged 1 commit into
envoyproxy:mainfrom
zirain:golangci-gci
Jan 14, 2023
Merged

lint: improve golanglint#911
Xunzhuo merged 1 commit into
envoyproxy:mainfrom
zirain:golangci-gci

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 14, 2023

Signed-off-by: hejianpeng hejianpeng2@huawei.com

cc @Xunzhuo

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain requested a review from a team as a code owner January 14, 2023 08:26
Comment thread .golangci.yml
- gosec
- misspell
- scopelint
- exportloopref
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN [runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #911 (1e583ea) into main (c3c97d0) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   63.48%   63.40%   -0.09%     
==========================================
  Files          53       53              
  Lines        7476     7476              
==========================================
- Hits         4746     4740       -6     
- Misses       2431     2436       +5     
- Partials      299      300       +1     
Impacted Files Coverage Δ
internal/gatewayapi/filters.go 82.01% <ø> (ø)
internal/gatewayapi/helpers.go 78.39% <ø> (ø)
internal/gatewayapi/listener.go 100.00% <ø> (ø)
internal/gatewayapi/resource.go 56.66% <ø> (ø)
internal/gatewayapi/route.go 89.02% <ø> (ø)
internal/xds/server/runner/runner.go 21.56% <ø> (ø)
internal/provider/kubernetes/controller.go 45.97% <0.00%> (-1.15%) ⬇️
internal/provider/kubernetes/helpers.go 77.86% <0.00%> (+2.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo enabled auto-merge (squash) January 14, 2023 09:00
@Xunzhuo Xunzhuo merged commit 545702c into envoyproxy:main Jan 14, 2023
@zirain zirain deleted the golangci-gci branch January 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants