Skip to content

chore: add devcontainer to gitignore#921

Merged
zirain merged 1 commit into
envoyproxy:mainfrom
Xunzhuo:dev-container
Jan 16, 2023
Merged

chore: add devcontainer to gitignore#921
zirain merged 1 commit into
envoyproxy:mainfrom
Xunzhuo:dev-container

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Jan 16, 2023

Signed-off-by: Xunzhuo bitliu@tencent.com

This is for maintainer/contributor who wants to use GitHub Codespaces custom workspace.

cc @zirain @arkodg

Signed-off-by: Xunzhuo <bitliu@tencent.com>
@Xunzhuo Xunzhuo marked this pull request as ready for review January 16, 2023 07:16
@Xunzhuo Xunzhuo requested a review from a team as a code owner January 16, 2023 07:16
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #921 (6932ce9) into main (545702c) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   63.48%   63.56%   +0.08%     
==========================================
  Files          53       53              
  Lines        7476     7476              
==========================================
+ Hits         4746     4752       +6     
+ Misses       2431     2427       -4     
+ Partials      299      297       -2     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 46.74% <0.00%> (-0.39%) ⬇️
internal/provider/kubernetes/predicates.go 64.20% <0.00%> (+2.27%) ⬆️
internal/provider/kubernetes/helpers.go 79.50% <0.00%> (+4.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zirain zirain merged commit d90a8e0 into envoyproxy:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants